activate missing check goal of maven-spotless-plugin#10968
activate missing check goal of maven-spotless-plugin#10968Pankraz76 wants to merge 1 commit intojenkinsci:masterfrom
check goal of maven-spotless-plugin#10968Conversation
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: . You can add the required label by adding a comment with the following text: |
pom.xml
Outdated
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>check</goal> |
There was a problem hiding this comment.
applying spotless changes everything this has to be done once or the config needs to be aligned with check. Its only possible because spotless is not activated by default...
| <goal>check</goal> | ||
| </goals> | ||
| <phase>validate</phase> | ||
| <phase>verify</phase> |
There was a problem hiding this comment.
|
consider this as positive and negative example. They need to apply spotless once then they can use it. or fix the config just like in PMD.... |
This comment was marked as resolved.
This comment was marked as resolved.
|
So the issue is caused when moving the plugin to the This changed the config somehow and then the entire project. Having applied spotless myself i know this could not be. When there is spotless there is out of sync possible. |
See JENKINS-XXXXX.
Testing done
Proposed changelog entries
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).